Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make window Parameter Dynamic #13656

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

GTRekter
Copy link

Subject

Linkerd Viz: Make window Parameter Dynamic

Problem

While we already have a list of acceptable values for the window parameter, it is currently hard-coded to 1m. In some edge cases, users may need to increase the scrape interval beyond one minute. This limitation causes the irate() functions to lack two data points within the one-minute window, resulting in an empty array.

Solution

Allow users to dynamically change the window parameter without needing to create local overrides in their browser. This is accomplished by checking the session storage for a value under the key metricsWindow. If a value exists, it is validated against the existing validMetricsWindows array. If the stored value is valid, it is used; otherwise, the default value is applied.

Validation

  • N/D

@GTRekter GTRekter requested a review from a team as a code owner February 13, 2025 12:27
Signed-off-by: Ivan Porta <[email protected]>
Signed-off-by: Ivan Porta <[email protected]>
@GTRekter GTRekter force-pushed the ivanp/dynamic-window branch from 3cb5520 to 138c20c Compare February 13, 2025 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant