Make window Parameter Dynamic #13656
Open
+37
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subject
Linkerd Viz: Make window Parameter Dynamic
Problem
While we already have a list of acceptable values for the window parameter, it is currently hard-coded to
1m
. In some edge cases, users may need to increase the scrape interval beyond one minute. This limitation causes theirate()
functions to lack two data points within the one-minute window, resulting in an empty array.Solution
Allow users to dynamically change the window parameter without needing to create local overrides in their browser. This is accomplished by checking the session storage for a value under the key
metricsWindow
. If a value exists, it is validated against the existingvalidMetricsWindows
array. If the stored value is valid, it is used; otherwise, the default value is applied.Validation