Add timeout and failureThreshold to multicluster probe #13061
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- This adds the `probeSpec.failureThreshold` and `probeSpec.timeout` fields to the Link CRD spec. - Likewise, the `gateway.probe.failureThreshold` and `gateway.probe.timeout` fields are added to the linkerd-multicluster chart, that are used to populate the new `mirror.linkerd.io/probe-failure-threshold` and `mirror.linkerd.io/probe-timeout` annotations in the gateway service (consumed by `linkerd mc link` to populate probe spec). - In the probe worker, we replace the hard-coded 50s timeout with the new timeout config (which now defaults to 30s). And the probe loop got refactored in order to not mark the gateway as unhealty until the consecutive failures threshold is reached.
adleong
reviewed
Sep 18, 2024
There was a problem hiding this comment.
This looks good but I have questions about the defaults (which preceded this PR). A probe timeout of 30s but interval of 3s means that in the case of a timeout, many probe requests will pile up, right? It seems like the interval should be at least as long as the timeout.
|
Good insight 👍, yes I've observed a pile up of one request when timeouts occur; the ticker goroutine blocks on run() consuming |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the
probeSpec.failureThresholdandprobeSpec.timeoutfields to the Link CRD spec.Likewise, the
gateway.probe.failureThresholdandgateway.probe.timeoutfields are added to the linkerd-multicluster chart, that are used to populate the newmirror.linkerd.io/probe-failure-thresholdandmirror.linkerd.io/probe-timeoutannotations in the gateway service (consumed bylinkerd mc linkto populate probe spec).In the probe worker, we replace the hard-coded 50s timeout with the new timeout config (which now defaults to 30s). And the probe loop got refactored in order to not mark the gateway as unhealty until the consecutive failures threshold is reached.