Allow to change OcCollector Service name via LINKERD2_PROXY_TRACING_S…

[GrigoriyMikhalkin]

Solves linkerd/linkerd2#11157

[codecov]

Codecov Report

Attention: Patch coverage is 50.00000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 67.63%. Comparing base (96124bc) to head (952951a).
Report is 256 commits behind head on main.

❗ Current head 952951a differs from pull request most recent head 3fd2bf1

Please upload reports for the commit 3fd2bf1 to get more accurate results.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2856      +/-   ##
==========================================
- Coverage   67.68%   67.63%   -0.05%     
==========================================
  Files         332      333       +1     
  Lines       15158    15182      +24     
==========================================
+ Hits        10259    10269      +10     
- Misses       4899     4913      +14     

Files	Coverage Δ
linkerd/app/src/oc_collector.rs	26.08% <ø> (ø)
linkerd/app/src/env.rs	59.15% <50.00%> (-0.24%)	⬇️

... and 14 files with indirect coverage changes

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4bd02c4...3fd2bf1. Read the comment docs.

[olix0r]

For the sake of consistency, we already have:

pub const ENV_TRACE_ATTRIBUTES_PATH: &str = "LINKERD2_PROXY_TRACE_ATTRIBUTES_PATH";

can we call this LINKERD2_PROXY_TRACE_SERVICE_NAME and group the definitions?

[GrigoriyMikhalkin]

Done

[GrigoriyMikhalkin]

@alpeb Do i understand it correctly that it was already implemented(by a different approach) in linkerd/linkerd2#13130? So this PR can be closed, i assume?

[sfleen]

Correct, we should be able to close this PR now.