Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add NodeSelector support to linkerd-failover chart #730

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

bezarsnba
Copy link

@bezarsnba bezarsnba commented Jun 2, 2024

  • This PR adds support for nodeSelector to the linkerd-failover chart. This allows users to specify which nodes in their Kubernetes cluster should be used to run the linkerd-failover pods.

This is useful for scenarios where you want to:

  • Run linkerd-failover on specific nodes with certain resources or hardware. For example, you might want to run it on nodes with more memory or specific hardware capabilities.
  • Isolate linkerd-failover pods from other workloads. This can be useful for security or performance reasons.

The nodeSelector option can be set in the values.yaml file of the chart.

Using

Users can utilize NodeSelector by setting the corresponding fields in the linkerd-failover graph values ​​file:

nodeSelector: 
  kubernetes.io/os: linux

Tests:

This PR includes unit and integration tests to ensure that NodeSelector works correctly. The tests were carried out in GKE.

Output of kubectl apply:

k get pods linkerd-failover-7fbbf98cf9-2pr4l -o jsonpath='{.spec.nodeSelector}'
{"kubernetes.io/os":"linux"}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant