-
Notifications
You must be signed in to change notification settings - Fork 33
release: 8.2537.106 #2055
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
release: 8.2537.106 #2055
Conversation
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…onfiguration for allowed versions (#2053)
WalkthroughThis PR updates dependency versions across multiple packages, pins nuqs via Renovate configuration, bumps the ESLint catalog in pnpm-workspace, and upgrades a GitHub Action. No source logic or public API declarations are changed. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested reviewers
Pre-merge checks (3 passed)✅ Passed checks (3 passed)
Tip 👮 Agentic pre-merge checks are now available in preview!Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.
Please see the documentation for more information. Example: reviews:
pre_merge_checks:
custom_checks:
- name: "Undocumented Breaking Changes"
mode: "warning"
instructions: |
Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).Please share your feedback with us on this Discord post. ✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🧹 Nitpick comments (3)
tooling/prettier/package.json (1)
20-20: LGTM; consider centralizing @types/node via catalog.To keep versions aligned across the workspace, add @types/node to pnpm-workspace.yaml catalog.
Apply in pnpm-workspace.yaml:
catalog: eslint: ^9.35.0 prettier: ^3.5.3 tailwindcss: ^3.4.17 typescript: ^5.8.3 + @types/node: ^22.18.1tooling/github/setup/action.yml (1)
7-11: Recommend ordering setup-node before pnpm/action-setup.Ensures PNPM installs under the intended Node version. Also consider caching lockfiles from monorepo roots.
runs: using: composite steps: - - uses: pnpm/action-setup@v4 - - uses: actions/setup-node@v5 + - uses: actions/setup-node@v5 with: node-version-file: ".nvmrc" cache: "pnpm" + cache-dependency-path: | + pnpm-lock.yaml + apps/**/pnpm-lock.yaml + packages/**/pnpm-lock.yaml + tooling/**/pnpm-lock.yaml + - uses: pnpm/action-setup@v4renovate.json (1)
12-16: Nuqs pin: add rangeStrategy at rule level to preserve exact pin.Without this, future updates might reintroduce ranges. Keep the pin stable until you’re ready to upgrade.
{ "matchPackageNames": ["nuqs"], - "allowedVersions": "<=2.4.3" + "allowedVersions": "<=2.4.3", + "rangeStrategy": "replace" }
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (9)
apps/api/package.json(3 hunks)apps/e2e/package.json(1 hunks)apps/web/package.json(4 hunks)packages/ufb-react/package.json(1 hunks)pnpm-workspace.yaml(1 hunks)renovate.json(1 hunks)tooling/eslint/package.json(1 hunks)tooling/github/setup/action.yml(1 hunks)tooling/prettier/package.json(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: integration-test
- GitHub Check: publish-api-docs
🔇 Additional comments (9)
tooling/eslint/package.json (1)
27-27: Bump to typescript-eslint ^8.43.0 looks good.Matches ESLint ^9.35.0 and TS 5.x in catalog. Please watch for peer warning noise in CI.
packages/ufb-react/package.json (1)
39-39: lucide-react patch bump is safe.No API changes expected; tree-shaking unaffected.
pnpm-workspace.yaml (1)
7-7: ESLint catalog -> ^9.35.0 is fine.Plugins in tooling/eslint appear compatible.
apps/e2e/package.json (1)
12-12: mysql2 patch bump for e2e is fine.No test harness changes needed.
apps/api/package.json (1)
29-32: Adjust dotenv imports for ESM-only upgrade
- Files under apps/api/src/domains/** and apps/api/src/configs/mysql.config.ts all use
import dotenv from 'dotenv'(with no explicitdotenv.config()), which will break when upgrading to v17 (ESM-only). Move your dotenv load to a top-level entrypoint with
import 'dotenv/config'or pin dotenv to v16.x.apps/web/package.json (4)
73-73: @babel/core patch bump approved
Verified that only apps/web/package.json declares “@babel/core” at ^7.28.4 and no conflicting versions exist in the workspace.
55-56: Confirm nuqs API compatibility with v2.4.3
Lockfile resolution shows [email protected] is locked (no caret) in pnpm-lock.yaml and apps/web/package.json; review allimport/require('nuqs')statements and ensuingnuqs.*usages to ensure no calls to features added after v2.4.x.
31-32: React Query bump verified; please smoke-test SSR & Devtools
Imports for@tanstack/react-queryand@tanstack/react-query-devtoolsare wired throughout the app (e.g. in_app.tsx, hooks, and UI components). No breaking changes expected—run a quick SSR render and verify the Devtools overlay locally to be safe.
47-47: Verify no runtime deprecation warnings after bumping i18next to ^25.5.2 – code uses next-i18next’s HOC (no direct i18next.init calls detected); check startup logs for any i18next warnings.
| "@testing-library/user-event": "^14.6.1", | ||
| "@types/jest": "^30.0.0", | ||
| "@types/node": "22.18.0", | ||
| "@types/node": "22.18.1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Verification agent
🧩 Analysis chain
@types/node 22.18.1: align across packages and with runtime Node.
🏁 Script executed:
#!/bin/bash
# Ensure all packages use the same @types/node and capture declared engines
rg -nP '"@types/node"\s*:\s*"[^\"]+"' -g '!**/node_modules/**'
rg -nP '"engines"\s*:\s*\{[^}]*"node"\s*:\s*"[^\"]+"' -n -C1 package.json pnpm-workspace.yaml || trueLength of output: 148
🏁 Script executed:
#!/bin/bash
set -e
# For each package.json (excluding node_modules), list @types/node and Node engine settings
for file in $(find . -type f -name 'package.json' -not -path '*/node_modules/*'); do
echo "=== $file ==="
echo "- @types/node dependency:"
rg -Hn -C1 '"@types/node"\s*:\s*".+"' "$file" || echo " (none)"
echo "- engines block:"
rg -Hn -C1 '"engines":' "$file" || echo " (none)"
echo "- node engine version:"
rg -Hn -C1 '"node"\s*:\s*".+"' "$file" || echo " (none)"
echo
doneLength of output: 2454
Align @types/node with runtime Node version
Bump @types/node from 22.18.1 to 22.19.0 in:
- apps/api/package.json (line 97)
- apps/web/package.json (line 82)
- tooling/prettier/package.json (line 20)
to match the root package’s engines.node ≥22.19.0.
🤖 Prompt for AI Agents
In apps/web/package.json around line 82, @types/node is pinned to 22.18.1 but
the repo's runtime requires Node ≥22.19.0; update the @types/node entry to
"22.19.0" to match the root engines.node and also ensure the same bump is
applied to apps/api/package.json (line 97) and tooling/prettier/package.json
(line 20) so all packages are consistent.
Summary by CodeRabbit