Minor UX improvements#6
Open
mjhomeschool wants to merge 2 commits into
Open
Conversation
mjhomeschool
commented
Sep 16, 2025
mjhomeschool
commented
- Starts with the Monitor, reidentify, and Preview buttons disabled.
- Selecting a config or an eye image enables the Monitor and Preview buttons.
- Reidentify remains disabled until seeds are recorded.
- Clicking Monitor or Reidentify while preview is showing automatically stops the preview. (Brief visual interruption in view between stopping preview and starting the new view.)
- While monitoring or reidentifying, the other two buttons are disabled.
- Clicking Stop Monitoring or Stop Reidentifying returns to preview. (Brief visual interruption in view between stopping and returning to preview.)
1. Starts with the Monitor, reidentify, and Preview buttons disabled. 2. Selecting a config or an eye image enables the Monitor and Preview buttons. 3. Reidentify remains disabled until seeds are recorded. 4. Clicking Monitor or Reidentify while preview is showing automatically stops the preview. (Brief visual interruption in view between stopping preview and starting the new view.) 5. While monitoring or reidentifying, the other two buttons are disabled. 6. Clicking Stop Monitoring or Stop Reidentifying returns to preview. (Brief visual interruption in view between stopping and returning to preview.)
The previous change disabled Reidentify until after seed is identified. The check to enable the Reidentify button was running before the seed field was populated, meaning that the button would only be enabled after the second completion of Monitor Blinks. This fix adjusts the timing so it happens after the first completion of Monitor Blinks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.