Skip to content

Conversation

dougbrn
Copy link
Collaborator

@dougbrn dougbrn commented Sep 17, 2025

Opening this early to keep track of CI. Major components of this PR have been reviewed as separate PRs into this branch, see #360, #366, #374

Resolves #355
Resolves #226
Resolves #354
Resolves #370
Resolves #356

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link

codecov bot commented Sep 17, 2025

Codecov Report

❌ Patch coverage is 97.57282% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 97.77%. Comparing base (bd8393e) to head (715e793).
⚠️ Report is 47 commits behind head on main.

Files with missing lines Patch % Lines
src/nested_pandas/series/dtype.py 89.28% 3 Missing ⚠️
src/nested_pandas/series/accessor.py 98.59% 1 Missing ⚠️
src/nested_pandas/series/nestedseries.py 93.75% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #363      +/-   ##
==========================================
- Coverage   98.25%   97.77%   -0.48%     
==========================================
  Files          19       19              
  Lines        1891     2026     +135     
==========================================
+ Hits         1858     1981     +123     
- Misses         33       45      +12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link

github-actions bot commented Sep 17, 2025

Before [bd8393e] <v0.5.2> After [079b24f] Ratio Benchmark (Parameter)
31.3±0.4ms 33.2±0.6ms 1.06 benchmarks.AssignSingleDfToNestedSeries.time_run
11.3±0.2ms 11.8±0.2ms 1.04 benchmarks.NestedFrameAddNested.time_run
1.31±0ms 1.36±0.01ms 1.03 benchmarks.NestedFrameReduce.time_run
901M 927M 1.03 benchmarks.ReadFewColumnsS3.peakmem_run
177M 179M 1.01 benchmarks.ReadFewColumnsHTTPS.peakmem_run
1.98±0.02s 2.00±0.03s 1.01 benchmarks.ReadFewColumnsS3.time_run
250M 250M 1 benchmarks.AssignSingleDfToNestedSeries.peakmem_run
135M 136M 1 benchmarks.CountNestedBy.peakmem_run
64.9±0.3ms 64.6±0.6ms 1 benchmarks.CountNestedBy.time_run
102M 102M 1 benchmarks.NestedFrameAddNested.peakmem_run

Click here to view all benchmarks.

@dougbrn dougbrn mentioned this pull request Sep 22, 2025
@dougbrn dougbrn changed the title [WIP] V0 6 Nested-Pandas V0.6 Sep 30, 2025
@dougbrn dougbrn marked this pull request as ready for review September 30, 2025 18:56
@dougbrn dougbrn requested a review from hombit September 30, 2025 18:57
Copy link
Collaborator

@hombit hombit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is great! Let's ask one of LSDB folks for a high-level review, mostly to review changes you listed in astronomy-commons/lsdb#1046

@dougbrn dougbrn requested a review from gitosaurus October 1, 2025 15:11
Copy link
Contributor

@gitosaurus gitosaurus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but a couple of these comments are worth addressing.

Copy link
Contributor

@gitosaurus gitosaurus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dougbrn dougbrn merged commit cf288d7 into main Oct 2, 2025
10 of 12 checks passed
@dougbrn dougbrn deleted the v0_6 branch October 2, 2025 20:36
@dougbrn dougbrn mentioned this pull request Oct 7, 2025
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants