-
Notifications
You must be signed in to change notification settings - Fork 91
TF-3834 Remember user sort #3913
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
dab246
wants to merge
4
commits into
master
Choose a base branch
from
improvement/tf-3834-remember-user-sort
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR has been deployed to https://linagora.github.io/tmail-flutter/3913. |
Screen.Recording.2025-07-30.at.09.29.11.mov |
Fixed demo.mov |
tddang-linagora
previously approved these changes
Jul 30, 2025
Please confirm that if we have no default sort yet (because we did never search something) then relevance applies. |
Yes it was done in this PR, look at the demo video you will see that. |
|
Signed-off-by: dab246 <[email protected]>
Signed-off-by: dab246 <[email protected]>
Signed-off-by: dab246 <[email protected]>
…eing the default Signed-off-by: dab246 <[email protected]>
684536e
to
44c14de
Compare
Updated 🧪 Should see list email displayed by sort order `Relevance` by default when search email successfully
:
: > Task :app:connectedDebugAndroidTest
: Starting 1 tests on Pixel_6_Pro_API_33(AVD) - 13
✅ 1. waitUntilVisible widgets with type "TwakeWelcomeView".
✅ 2. tap widgets with text "Use company server".
✅ 3. waitUntilVisible widgets with type "LoginView".
✅ 4. tap widgets with type "TextField" descending from widgets with key [<'dns_lookup_input_form'>].
✅ 5. enterText widgets with type "TextField" descending from widgets with key [<'dns_lookup_input_form'>].
✅ 6. waitUntilVisible widgets with text "bob".
✅ 7. tap widgets with text "Next".
✅ 8. waitUntilVisible widgets with key [<'base_url_form'>] descending from widgets with type "LoginView".
✅ 9. tap widgets with type "TextField" descending from widgets with key [<'base_url_form'>].
✅ 10. enterText widgets with type "TextField" descending from widgets with key [<'base_url_form'>].
✅ 11. waitUntilVisible widgets with text containing 69cc60058c08.ngrok-free.app.
✅ 12. tap widgets with text "Next".
✅ 13. waitUntilVisible widgets with key [<'credential_input_form'>] descending from widgets with type "LoginView".
✅ 14. enterText widgets with type "TextField" descending from widgets with key [<'login_username_input'>].
✅ 15. waitUntilVisible widgets with text "[email protected]".
✅ 16. tap widgets with type "TextField" descending from widgets with key [<'login_password_input'>].
✅ 17. enterText widgets with type "TextField" descending from widgets with key [<'login_password_input'>].
✅ 18. tap widgets with key [<'loginSubmitForm'>].
✅ Should see list email displayed by sort order `Relevance` by default when search email successfully
Test summary:
📝 Total: 1
✅ Successful: 1
❌ Failed: 0
⏩ Skipped: 0
📊 Report: ../Projects/tmail-flutter/build/app/reports/androidTests/connected/index.html
⏱️ Duration: 32s demo-e2e.webm |
tddang-linagora
approved these changes
Aug 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
#3834
Resolved
Screen.Recording.2025-07-29.at.15.31.08.online-video-cutter.com.mp4
demo-mobile.webm
demo-e2e.webm