Skip to content

TF-3834 Remember user sort #3913

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

dab246
Copy link
Member

@dab246 dab246 commented Jul 29, 2025

Issue

#3834

Resolved

  • Web:
Screen.Recording.2025-07-29.at.15.31.08.online-video-cutter.com.mp4
  • Mobile:
demo-mobile.webm
  • E2E:
🧪 Should see list email displayed by sort order `Relevance` by default when search email successfully
        : 
        : > Task :app:connectedDebugAndroidTest
        : Starting 1 tests on Pixel_6_Pro_API_33(AVD) - 13
        ✅   1. waitUntilVisible widgets with type "TwakeWelcomeView".
        ✅   2. tap widgets with text "Use company server".
        ✅   3. waitUntilVisible widgets with type "LoginView".
        ✅   4. tap widgets with type "TextField" descending from widgets with key [<'dns_lookup_input_form'>].
        ✅   5. enterText widgets with type "TextField" descending from widgets with key [<'dns_lookup_input_form'>].
        ✅   6. waitUntilVisible widgets with text "bob".
        ✅   7. tap widgets with text "Next".
        ✅   8. waitUntilVisible widgets with key [<'base_url_form'>] descending from widgets with type "LoginView".
        ✅   9. tap widgets with type "TextField" descending from widgets with key [<'base_url_form'>].
        ✅  10. enterText widgets with type "TextField" descending from widgets with key [<'base_url_form'>].
        ✅  11. waitUntilVisible widgets with text containing 69cc60058c08.ngrok-free.app.
        ✅  12. tap widgets with text "Next".
        ✅  13. waitUntilVisible widgets with key [<'credential_input_form'>] descending from widgets with type "LoginView".
        ✅  14. enterText widgets with type "TextField" descending from widgets with key [<'login_username_input'>].
        ✅  15. waitUntilVisible widgets with text "[email protected]".
        ✅  16. tap widgets with type "TextField" descending from widgets with key [<'login_password_input'>].
        ✅  17. enterText widgets with type "TextField" descending from widgets with key [<'login_password_input'>].
        ✅  18. tap widgets with key [<'loginSubmitForm'>].
✅ Should see list email displayed by sort order `Relevance` by default when search email successfully

Test summary:
📝 Total: 1
✅ Successful: 1
❌ Failed: 0
⏩ Skipped: 0
📊 Report: ../Projects/tmail-flutter/build/app/reports/androidTests/connected/index.html
⏱️  Duration: 32s
demo-e2e.webm

Copy link

This PR has been deployed to https://linagora.github.io/tmail-flutter/3913.

@tddang-linagora
Copy link
Collaborator

tddang-linagora commented Jul 30, 2025

  • Search sort resets to default on reload browser
Screen.Recording.2025-07-30.at.09.29.11.mov

@dab246
Copy link
Member Author

dab246 commented Jul 30, 2025

  • Search sort resets to default on reload browser

Fixed

demo.mov

@chibenwa
Copy link
Member

Please confirm that if we have no default sort yet (because we did never search something) then relevance applies.

@dab246
Copy link
Member Author

dab246 commented Aug 1, 2025

Please confirm that if we have no default sort yet (because we did never search something) then relevance applies.

Yes it was done in this PR, look at the demo video you will see that.

@hoangdat
Copy link
Member

hoangdat commented Aug 1, 2025

  • integration test to make sure it was relevant by default

@dab246
Copy link
Member Author

dab246 commented Aug 4, 2025

  • integration test to make sure it was relevant by default

Updated

🧪 Should see list email displayed by sort order `Relevance` by default when search email successfully
        : 
        : > Task :app:connectedDebugAndroidTest
        : Starting 1 tests on Pixel_6_Pro_API_33(AVD) - 13
        ✅   1. waitUntilVisible widgets with type "TwakeWelcomeView".
        ✅   2. tap widgets with text "Use company server".
        ✅   3. waitUntilVisible widgets with type "LoginView".
        ✅   4. tap widgets with type "TextField" descending from widgets with key [<'dns_lookup_input_form'>].
        ✅   5. enterText widgets with type "TextField" descending from widgets with key [<'dns_lookup_input_form'>].
        ✅   6. waitUntilVisible widgets with text "bob".
        ✅   7. tap widgets with text "Next".
        ✅   8. waitUntilVisible widgets with key [<'base_url_form'>] descending from widgets with type "LoginView".
        ✅   9. tap widgets with type "TextField" descending from widgets with key [<'base_url_form'>].
        ✅  10. enterText widgets with type "TextField" descending from widgets with key [<'base_url_form'>].
        ✅  11. waitUntilVisible widgets with text containing 69cc60058c08.ngrok-free.app.
        ✅  12. tap widgets with text "Next".
        ✅  13. waitUntilVisible widgets with key [<'credential_input_form'>] descending from widgets with type "LoginView".
        ✅  14. enterText widgets with type "TextField" descending from widgets with key [<'login_username_input'>].
        ✅  15. waitUntilVisible widgets with text "[email protected]".
        ✅  16. tap widgets with type "TextField" descending from widgets with key [<'login_password_input'>].
        ✅  17. enterText widgets with type "TextField" descending from widgets with key [<'login_password_input'>].
        ✅  18. tap widgets with key [<'loginSubmitForm'>].
✅ Should see list email displayed by sort order `Relevance` by default when search email successfully

Test summary:
📝 Total: 1
✅ Successful: 1
❌ Failed: 0
⏩ Skipped: 0
📊 Report: ../Projects/tmail-flutter/build/app/reports/androidTests/connected/index.html
⏱️  Duration: 32s
demo-e2e.webm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants