fix: improve dataset processing / loading speeds - #149
Conversation
Signed-off-by: Dogac Eldenk <dogacel@gmail.com>
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5f4f3495f5
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| .claude/ | ||
| wandb/ | ||
| data/ | ||
| ./data/ |
There was a problem hiding this comment.
Restore the data directory ignore pattern
With this pattern, root-level data/ is no longer ignored: I checked the updated file with git check-ignore -v data/foo and it returns no match, while /data/ or the previous data/ pattern does match. This makes local training datasets under data/ show up as untracked files and increases the chance of accidentally staging large/private data.
Useful? React with 👍 / 👎.
torch.saveMeasured on the full 1M-conversation corpus, 64 workers, Qwen3-8B tokenizer,
max_seq_length=16384.