PaymentBandwidth uses HtlcView
#1462
Open
+180
−62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 14516181401Details
💛 - Coveralls |
guggero
reviewed
Apr 9, 2025
GeorgeTsagk
force-pushed
the
aux-bandwidth-htlcview
branch
3 times, most recently
from
b3e79c5 to
1f94c7a
Compare
GeorgeTsagk
force-pushed
the
aux-bandwidth-htlcview
branch
from
1f94c7a to
9bd9d79
Compare
guggero
reviewed
Apr 15, 2025
GeorgeTsagk
force-pushed
the
aux-bandwidth-htlcview
branch
2 times, most recently
from
98260c9 to
8e9b450
Compare
To make `PaymentBandwidth` more readable, we separate the main codepaths into helper functions. One is used when we're directly comparing asset units to each other, and the other one is the path that calculates an msat amount based on an RFQ quote.
We now make use of the AuxHtlcView to calculate a more precise value of our local balance. This is using the ComputeView helper in order to manually process HTLC adds from our side, providing us with the correct value of local balance. We also add the DecodedView as a return value of the helper function, but this will only be used in the next commit for verbose logging.
We add a trace log which includes a pretty print of the HTLCs that are part of our local update log.
GeorgeTsagk
force-pushed
the
aux-bandwidth-htlcview
branch
from
8e9b450 to
3182e35
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When
AuxTrafficShaper.PaymentBandwidthis called asynchonously we could previously report the same bandwidth for 2 different HTLCs that are validating whether they can be added to the channel. This could lead to false-positives and payment failures as the latter HTLC should be checked against the correct bandwidth.Instead of always consulting the commitment blob on what the current asset balance is, we now use the existing helper
ComputeViewto get a more precise representation of the asset balance, which is enabled by the new argumentlnwallet.HtlcView.