- 
                Notifications
    
You must be signed in to change notification settings  - Fork 122
 
Revert "Merge pull request #1028 from starius/downgrade-deps" #1031
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
          Summary of ChangesHello @sputn1ck, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request effectively reverses a previous change that had downgraded project dependencies. It primarily focuses on upgrading the project's Go version to 1.24.6 and updating several critical dependencies like  Highlights
 Ignored Files
 Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either  
 Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a  Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
  | 
    
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request reverts a previous commit that downgraded dependencies, effectively upgrading them and adding new documentation generation capabilities. The changes look mostly good, with dependency versions updated across several files (go.mod, Dockerfile, release.sh) and code adapted to the new dependency APIs in loopout.go. The new docs and docs-check Makefile targets are a welcome addition for keeping documentation up-to-date.
However, I've found a few issues:
- A minor copy-paste error in an error message in 
cmd/loop/docs.go. - A potentially confusing version number in an example in 
docs/release.md. - The Go versions in 
looprpc/go.modandswapserverrpc/go.modare downgraded, which is inconsistent with the upgrade in the rootgo.mod. This should be corrected to avoid potential build issues and confusion. 
This reverts commit b11c959, reversing changes made to 0a182ee.