SendCoins: use SatPerVbyte instead of SatPerByte #240
Conversation
SatPerByte is deprecated.
|
@bhandras: review reminder |
| SendCoins(ctx context.Context, addr btcutil.Address, | ||
| amount btcutil.Amount, sendAll bool, confTarget int32, | ||
| satsPerByte int64, label string) (string, error) | ||
| satsPerVByte chainfee.SatPerVByte, label string) (string, error) |
There was a problem hiding this comment.
This would lead to breaks in other implementations of this interface, right?
There was a problem hiding this comment.
Yes. I think this if ok, given satsPerByte is deprecated and can be removed in LND. So users and other implementations of this method are force to update their code.
There was a problem hiding this comment.
Pull Request Overview
This PR updates the SendCoins method to use proper fee rate types by changing the parameter type from int64 to chainfee.SatPerVByte and updating the RPC request field from SatPerByte to SatPerVbyte. This aligns with the LND API's transition to virtual byte-based fee rates.
Key changes:
- Updated parameter type from
int64 satsPerBytetochainfee.SatPerVByte satsPerVBytein both interface and implementation - Changed RPC request field from
SatPerBytetoSatPerVbytewith proper type conversion touint64 - Updated documentation comments to reflect the new parameter name
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Tagged it as |
4 participants
SatPerByte is deprecated.
Pull Request Checklist
in
lnd_services.goare updated.macaroon_recipes.goif your PR adds a new method that is calleddifferently than the RPC method it invokes.