channels: create test cases for two new bug fixes #1089
Merged
+113
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GeorgeTsagk
approved these changes
Jun 16, 2025
github-project-automation
bot
moved this from 🆕 New
to 👀 In review
in Taproot-Assets Project Board
guggero
force-pushed
the
keysend-one-sat
branch
2 times, most recently
from
301da81 to
cb03804
Compare
ViktorTigerstrom
approved these changes
Jun 17, 2025
Tests an edge case that previously lead to a force close due to the following error: unable to sort commitment transaction: output and allocation size mismatch with error Having a below-dust satoshi balance is only allowed when there is no asset balance. But since such a dust output isn't materialized on-chain, tapd needs to filter it out correctly and not create an allocation.
This commit tests that the routing policy of the correct peer (the policy pointing toward the recipient of an invoice) is included in an asset invoice.
github-project-automation
bot
moved this from 👀 In review
to ✅ Done
in Taproot-Assets Project Board
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on lightninglabs/taproot-assets#1601, creates test cases for the two bug fixes included there.