[sql-34]: actions: some basic clean-up of the firewall actions code #1065
+550
−543
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In preparation for adding a SQL implementation of the the Actions DB, we move all kvdb CRUD code to a dedicated file.
To better represent the interface and to free up the use of the ActionsDB name as this will be used to represent the full Actions DB in an upcoming commit.
The SessionID is already present in the Action itself and so this does not need to be passed in as its own parameter.
ellemouton
added
sql-ize
no-changelog
ViktorTigerstrom
approved these changes
May 8, 2025
| @@ -48,7 +48,7 @@ type ConfigImpl struct { | |||
|
|
|||
| // ActionsDB can be used by rules to list any past actions that were | |||
| // made for the specific session or feature. | |||
| ActionsDB firewalldb.ActionsDB | |||
| ActionsDB firewalldb.ActionsListDB | |||
There was a problem hiding this comment.
nit: Could potentially rename the ActionsDB field in the config as well as the GetActionsDB in the interface as it's publicly exposed? I don't know what your upcoming commit that will use the ActionsDB name to represent the full Actions DB looks like though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds some initial clean up of the actions code in preparation for adding a SQL implementation.
Part of #917