Skip to content

Conversation

@tankyleo
Copy link
Contributor

@tankyleo tankyleo commented Dec 3, 2025

Describe how to configure Knots v29+ to work with 0FC channels

@ldk-reviews-bot
Copy link

ldk-reviews-bot commented Dec 3, 2025

👋 Thanks for assigning @TheBlueMatt as a reviewer!
I'll wait for their review and will help manage the review process.
Once they submit their review, I'll check if a second reviewer would be helpful.

@tankyleo tankyleo requested a review from benthecarman December 3, 2025 07:05
@tankyleo
Copy link
Contributor Author

tankyleo commented Dec 3, 2025

Have not tested 0FC channels against Knots with this configuration, this is my best read of the release notes and example configuration file.

@tankyleo tankyleo force-pushed the 0FC-channels-knots-settings branch 2 times, most recently from 96d6bef to 09ede63 Compare December 3, 2025 07:21
@codecov
Copy link

codecov bot commented Dec 3, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.87%. Comparing base (311ad94) to head (5a1fc7d).
⚠️ Report is 2 commits behind head on 0.2.

Additional details and impacted files
@@            Coverage Diff             @@
##              0.2    #4256      +/-   ##
==========================================
+ Coverage   88.86%   88.87%   +0.01%     
==========================================
  Files         180      180              
  Lines      138117   138117              
  Branches   138117   138117              
==========================================
+ Hits       122736   122751      +15     
+ Misses      12568    12549      -19     
- Partials     2813     2817       +4     
Flag Coverage Δ
fuzzing 20.85% <ø> (ø)
tests 88.71% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Collaborator

@TheBlueMatt TheBlueMatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You mentioned on Discord that you hadn't done full testing with Knots, honestly given that I feel like we might as well just say "note that Knots by default blocks these transactions, do not use Knots with a lightning node" rather than trying to provide specific configs we only assume work.

Discourage people from running Knots with LDK
@tankyleo tankyleo force-pushed the 0FC-channels-knots-settings branch from 09ede63 to 5a1fc7d Compare December 3, 2025 16:09
@tankyleo tankyleo requested a review from TheBlueMatt December 3, 2025 16:12
@TheBlueMatt TheBlueMatt merged commit 0df6d79 into lightningdevkit:0.2 Dec 3, 2025
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants