#3775 follow-ups #3945
#3775 follow-ups #3945
Conversation
In 85cc09e, we updated this member to include the sum of dust HTLCs on the commitment transaction, any elided anchors, as well as the sum of the msat amounts rounded down from non-dust HTLCs.
`TxBuilder` will eventually be a public trait, and this debug assertion could catch any inconsistencies in the implementations of this trait.
|
👋 Thanks for assigning @TheBlueMatt as a reviewer! |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3945 +/- ##
==========================================
- Coverage 89.02% 89.01% -0.02%
==========================================
Files 167 167
Lines 121800 121806 +6
Branches 121800 121806 +6
==========================================
- Hits 108434 108421 -13
- Misses 10953 10978 +25
+ Partials 2413 2407 -6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| @@ -774,6 +774,8 @@ pub enum Balance { | |||
| amount_satoshis: u64, | |||
| /// The transaction fee we pay for the closing commitment transaction. This amount is not | |||
| /// included in the [`Balance::ClaimableOnChannelClose::amount_satoshis`] value. | |||
| /// This amount includes the sum of dust HTLCs on the commitment transaction, any elided anchors, | |||
There was a problem hiding this comment.
nit you might heave meant to include a newline here to create a paragraph break. when rustdocs renders it ignores line breaks unless there's a full empty line between sections of text, which creates a paragraph break. Makes the in-source docs look a little tall but the rendering isn't that bad.
|
👋 The first review has been submitted! Do you think this PR is ready for a second reviewer? If so, click here to assign a second reviewer. |
Quick follow-ups from #3775, will address the ones remaining in standalone PRs