Only mark all mon updates complete if there are no blocked updates #3907
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
handle_new_monitor_update!
, we correctly check that the channel doesn't have any blocked monitor updates pending before callinghandle_monitor_update_completion!
(which callsChannel::monitor_updating_restored
, which in turn assumes that all generatedChannelMonitorUpdate
s, including blocked ones, have completed).We, however, did not do the same check at several other places where we called
handle_monitor_update_completion!
. Specifically, after a monitor update completes during reload (processed via aBackgroundEvent
or when monitor update completes async, we didn't check if there were any blocked monitor updates before completing).Here we add the missing check, as well as an assertion in
Channel::monitor_updating_restored
.