Skip to content

[Custom Transactions] Define the TxBuilder trait #3761

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

tankyleo
Copy link
Contributor

    [Custom Transactions] Define the `TxBuilder` trait
    
    This trait will give users of LDK the ability to create arbitrary
    commitment transactions given a snapshot of the Lightning state machine.
    
    For now, we only make it available for internal use. Once further
    work elsewhere in LDK is complete, this trait will become public.

@ldk-reviews-bot
Copy link

👋 Hi! I see this is a draft PR.
I'll wait to assign reviewers until you mark it as ready for review.
Just convert it out of draft status when you're ready for review!

@tankyleo
Copy link
Contributor Author

@TheBlueMatt I believe we are at a good point where we can define this API internally. Still much work to do before making this public, but I thought we could get this done now let me know.

Copy link

codecov bot commented Apr 30, 2025

Codecov Report

Attention: Patch coverage is 86.97917% with 25 lines in your changes missing coverage. Please review.

Project coverage is 89.38%. Comparing base (559a784) to head (3a2f8c9).
Report is 11 commits behind head on main.

Files with missing lines Patch % Lines
lightning/src/ln/channel.rs 53.70% 25 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3761      +/-   ##
==========================================
+ Coverage   89.14%   89.38%   +0.24%     
==========================================
  Files         157      158       +1     
  Lines      123997   126674    +2677     
  Branches   123997   126674    +2677     
==========================================
+ Hits       110531   113227    +2696     
- Misses      10786    10818      +32     
+ Partials     2680     2629      -51     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

This trait will give users of LDK the ability to create arbitrary
commitment transactions given a snapshot of the Lightning state machine.

For now, we only make it available for internal use. Once further
work elsewhere in LDK is complete, this trait will become public.
@tankyleo tankyleo force-pushed the tx-builder branch 2 times, most recently from d524909 to f55079f Compare May 5, 2025 01:55
@tankyleo
Copy link
Contributor Author

tankyleo commented May 5, 2025

API is not stable yet I am still making big changes to it. Will reopen soon.

@tankyleo tankyleo closed this May 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants