Update crate tagline to highlight that it works #3666
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've assigned @jkczyz as a reviewer! |
G8XSU
approved these changes
Mar 13, 2025
| @@ -5,9 +5,8 @@ authors = ["Matt Corallo"] | |||
| license = "MIT OR Apache-2.0" | |||
| repository = "https://github.com/lightningdevkit/rust-lightning/" | |||
| description = """ | |||
| A Bitcoin Lightning library in Rust. | |||
| A Complete Bitcoin Lightning library in Rust. | |||
| Does most of the hard work, without implying a specific runtime, requiring clients implement basic network logic, chain interactions and disk storage. | |||
There was a problem hiding this comment.
nit: does most of the hard work, vaguely suggests incomplete pieces.
"Handles the core functionality of the Lightning Network, allowing clients to implement custom wallet, chain interactions, storage and network logic without enforcing a specific runtime."
There was a problem hiding this comment.
Yeah, that reads better, IMO.
jkczyz
reviewed
Mar 13, 2025
| @@ -5,9 +5,8 @@ authors = ["Matt Corallo"] | |||
| license = "MIT OR Apache-2.0" | |||
| repository = "https://github.com/lightningdevkit/rust-lightning/" | |||
| description = """ | |||
| A Bitcoin Lightning library in Rust. | |||
| A Complete Bitcoin Lightning library in Rust. | |||
There was a problem hiding this comment.
Not sure how much that adds or what should be capitalized, TBH :P
| @@ -5,9 +5,8 @@ authors = ["Matt Corallo"] | |||
| license = "MIT OR Apache-2.0" | |||
| repository = "https://github.com/lightningdevkit/rust-lightning/" | |||
| description = """ | |||
| A Bitcoin Lightning library in Rust. | |||
| A Complete Bitcoin Lightning library in Rust. | |||
| Does most of the hard work, without implying a specific runtime, requiring clients implement basic network logic, chain interactions and disk storage. | |||
There was a problem hiding this comment.
Yeah, that reads better, IMO.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.