-
Notifications
You must be signed in to change notification settings - Fork 399
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LSPS5 implementation #3662
Open
martinsaposnic
wants to merge
12
commits into
lightningdevkit:main
Choose a base branch
from
martinsaposnic:lsps5
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
LSPS5 implementation #3662
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
26e1d68
Separate time functionality into dedicated feature flag
martinsaposnic 6e43a5f
fixup: time is a feature, not a cfg flag, so delete it from check-cfg
martinsaposnic afe320b
fixup: Improvements on LSPSDateTime
martinsaposnic 4e65642
Add custom URL parser for LSPS5.
martinsaposnic ed2f940
Add messaging types for webhook operations
martinsaposnic 17db0db
Add LSPS5 event enums for webhook operations
martinsaposnic 62d336e
fixup: Provide concrete guidance on event.rs for new event SendWebhoo…
martinsaposnic 44f8167
Add LSPS5 webhook service implementation
martinsaposnic f178b29
Add LSPS5 webhook client implementation
martinsaposnic 9eb7681
Add LSPS5 module structure
martinsaposnic 813802c
Integrate LSPS5 with liquidity manager
martinsaposnic cb9404e
Add tests for LSPS5 client and service. Also tests for checking the c…
martinsaposnic File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this now needs to be feature-gated on
time
, same below, no? Or are we doing this in the follow-up also addressing LSPS2?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, this is coming in a follow-up. If I change it now, I'd also need to update LSPS2-related files, making this PR even bigger