Skip to content

Conversation

@jkczyz
Copy link
Contributor

@jkczyz jkczyz commented Oct 30, 2025

Bump the ldk-node dependency to support splicing.

@ldk-reviews-bot
Copy link

ldk-reviews-bot commented Oct 30, 2025

👋 Thanks for assigning @tnull as a reviewer!
I'll wait for their review and will help manage the review process.
Once they submit their review, I'll check if a second reviewer would be helpful.

@jkczyz jkczyz self-assigned this Oct 30, 2025
@tnull tnull self-requested a review October 30, 2025 17:39
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems we'll need to check in a separate Cargo-minimal.lock file that we use for MSRV CI.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I usually run cargo with our MSRV, but hadn't done so here. Should I just build using cargo +1.75.0 for any Cargo.lock updates. Not sure what the best practices are.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I usually run cargo with our MSRV, but hadn't done so here. Should I just build using cargo +1.75.0 for any Cargo.lock updates. Not sure what the best practices are.

No, I think we want to keep the Cargo.lock on current stable and bump it now and then when we see a requirement. Most projects also check in a separate Cargo-minimal.lock file with the MSRV, see for example https://github.com/rust-bitcoin/rust-bitcoin/blob/master/Cargo-minimal.lock

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants