Introduce ImageSample.sample_table #283
Merged
+55
−48
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is an important refactoring, so that we do not access `.inner.sample` in multiple places in the code. * It will later allow a generalization, having a common `Sample` abstract class, e.g. shared with `VideoSample`. * The `.inner.sample` access would not be allowed in other languages, as it goes directly to the private data.
Contributor
Author
|
This PR does most of the cleanup needed for the followup refactoring, see the draft PR #284 |
lukas-lightly
commented
Dec 10, 2025
michal-lightly
approved these changes
Dec 11, 2025
lukas-lightly
deleted the
lukas-lig-8260-python-interface-introduce-videosample
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What has changed and why?
This is an important refactoring, so that we do not access
.inner.sampledirectly at multiple places in the code.Sampleabstract class, e.g. shared withVideoSample..inner.sampleaccess would not be allowed in other languages, as it goes directly to the private data.How has it been tested?
Existing tests
Did you update CHANGELOG.md?