Skip to content

Rewrite dsDictionaries to R package#57

Draft
erikzwart wants to merge 42 commits into
masterfrom
setup-R-package
Draft

Rewrite dsDictionaries to R package#57
erikzwart wants to merge 42 commits into
masterfrom
setup-R-package

Conversation

@erikzwart
Copy link
Copy Markdown
Contributor

@erikzwart erikzwart commented Jan 5, 2024 •
edited
Loading

  • setup library(dsDictionaries) R package
  • update README
  • include lifecycle core 2_6 transformation into 'new' dictionary format
  • make lifecycle core 3_0 available as dataset data(lifecycle_core_3_0)
  • add tests for datasets (data.R)

How to run

devtools::load_all()
library(dsDictionaries)
data(lifecycle_core_3_0)

devtools::check()

@erikzwart erikzwart requested a review from marikaris January 5, 2024 14:03
erikzwart added 13 commits January 8, 2024 13:58
@erikzwart
add categories tests
d29b18b
@erikzwart
data(lifecycle_core_2_5) documentation added (data.R)
927d7fb 
Add readme text for developers
@erikzwart
Added NEWS.md
9454a5c 
Update lifecycle_core_2_6.R to create changelog (NEWS)
@erikzwart
update NEWS.md
2ac0731
@erikzwart
data(lifecycle_outcome_1_6) documentation added (data.R)
7de312d 
data(lifecycle_outcome_1_5) documentation added (data.R)

update NEWS.md
@erikzwart
data(athlete_urban_1_3) documentation added (data.R)
a085e0a 
data(athlete_urban_1_2) documentation added (data.R)

update NEWS.md
@erikzwart
data(athlete_outcome_1_3) documentation added (data.R)
5c218c5 
data(athlete_outcome_1_2) documentation added (data.R)

update NEWS.md
@erikzwart
data(athlete_chemicals_1_2) documentation added (data.R)
bf1a28e 
data(athlete_chemicals_1_1) documentation added (data.R)

update NEWS.md

update test-data.R
@erikzwart
update test-data.R to be generic
745fa5e
@erikzwart
update test-data.R split athlete and lifecycle dataset test
6889d33
@erikzwart
data(lifecycle_methyl_1_5) documentation added (data.R)
38b0087 
update test-data.R, handle no repeats in dataset
@erikzwart
add test unique Variables
bb87ad4 
update datasets
@erikzwart
add test Variable column names, types and valueType
9ce0bcb
@StuartWheater
Copy link
Copy Markdown

StuartWheater commented Jan 15, 2024

The latest version of R is 4.3.2. DESCRIPTION specifies version of R should be >= 2.10, has it been tested with such old version of R?

clemens-tolboom
clemens-tolboom reviewed Feb 1, 2024
View reviewed changes
Copy link
Copy Markdown

@clemens-tolboom clemens-tolboom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some non-R feedback

Comment thread README.md Outdated
Comment thread README.md Outdated
Comment thread README.md Outdated
Comment thread README.md Outdated
Comment thread README.md Outdated
Comment thread README.md Outdated
Comment thread README.md Outdated
Comment thread README.md Outdated
Comment thread README.md Outdated
clemens-tolboom
clemens-tolboom reviewed Feb 1, 2024
View reviewed changes
Comment thread README.md Outdated
clemens-tolboom
clemens-tolboom reviewed Feb 1, 2024
View reviewed changes
Comment thread README.md Outdated
@erikzwart
bump version athlete (chemicals 2_0, outcome 2_0, urban 2_0)
2deddea 
bump version lifecycle (core 3_0, outcome 2_0)

partialy replaced lifecycle methyl 1_5 with methyl cord blood 2_0
@erikzwart
Update DESCRIPTION depends on R version 4.3.0 or higher
d619395
@erikzwart
Copy link
Copy Markdown
Contributor Author

erikzwart commented Feb 6, 2024

The latest version of R is 4.3.2. DESCRIPTION specifies version of R should be >= 2.10, has it been tested with such old version of R?

DESCRIPTION has been changed to R >= 4.3.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@marikaris marikaris Awaiting requested review from marikaris

1 more reviewer

@clemens-tolboom clemens-tolboom clemens-tolboom left review comments

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@erikzwart @StuartWheater @clemens-tolboom