fix(providers): inherit reasoning metadata for renamed key destinations - #4370
Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
✅ Deterministic PR hygiene checks passed. |
리뷰 · 우선순위 56 / 80이 PR은 CommandCode처럼 이름이 바뀐 API-key preset이, fixed destination matcher에 걸릴 때 비어 있는 reasoning-effort 메타를 registry에서 상속하게 합니다 (#4308). 이미 올라간 #4282 table row와 별개로 “destination metadata 공백”만 고칩니다. provider identity·routing·OAuth matching·다른 capability 축은 건드리지 않는다고 본문에 명시되어 있습니다. 현재 checkout draft·base CommandCode 같은 renamed key destination은 사용자 설정에 자주 남고, reasoning ladder가 비면 클라이언트 export(DSH/ZCode)와 Codex inbound reasoning drop으로 이어집니다. 변경이 derive 한 함수와 테스트·문서에 묶여 있어 리스크 대비 효과가 큽니다. 충돌만 아니면 READY 후보에 가깝습니다. 경로 테스트 unknown-model - registry empty picker policy([]) vs provider-wide medium override 시나리오가 나뉘어 있어 좋습니다. export 테스트의 모델 id가 현재 catalog와 어긋나도 fixture로는 충분해 보입니다. 충돌 - 현 브랜치 그대로 머지 불가. 메인테이너의 판단이 필요한 지점
너의 추천 이 댓글은 grok-bot이 작성했습니다 |
Carry #4100 with case-preserving keys, normalized editor adoption, and recoverable native root-stamp provenance. Co-authored-by: HarryZhou <2373256746@qq.com>
Refs #4308. Fill missing metadata through existing destination matching while preserving explicit provider and model overrides.
Refs #3377. Add strict management writes, per-axis load recovery, exact model IDs, and declaration-preserving DTO/mutation paths. Upstream tier/video activation remains evidence-gated.
…bilities Refs #3377 and original text-only request #3268 by @turin-dev. Reuse existing vision description/omission handling, preserve exact model keys and legacy fallback.
a2fb378 to
6c29ffa
Compare
Keep this layer's exact modelCapabilities storage and validation, and take origin/dev's HMAC admission imports plus current structure ownership notes.
Keep this layer's exact-modality text-only consumer note and retain the Cline CLI registry-parity sentence from origin/dev.
Keep reviewer selectors and modelCapabilities together in config schema, editor adoption, and management tests; retain both structure ownership notes.
Keep renamed-destination reasoning inheritance with the stacked modelCapabilities, text-only, and reviewer contracts.
The dev merge appended this layer's cross-reference notes after sections origin/dev had added, so they rendered under Context relay ownership, the OAuth Fast Tier section, and the capability section. Move them back beside the prose they describe; no wording changes.
…t-only Carry the lower layer's note placement and keep this layer's text-only consumer and input-declaration notes beside the sections they describe.
Carry the lower layers' note placement, put this layer's reviewer note with them, and give the reviewer heading the blank line Markdown needs to render it as a heading.
Carry the lower layers' note placement and keep this layer's renamed-destination note with them, above the OAuth Fast Tier section.
Keep both sides' config-load degradation tests and the stack's structure notes beside the sections origin/dev added.
One conflict in structure/adapters/registry.md: both sides appended a new section at the same anchor. Kept the lane capability/reviewer paragraphs and dev SWE-2 effort section.
|
Maintainer integration record — providers lane tip, merged by @lidge-jun. Tip of the cumulative providers stack. Merging with a merge commit lands the lane and lets GitHub close each link as
|
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
1 participant
Summary
A renamed API-key preset such as CommandCode now inherits missing reasoning-effort tables from its existing fixed destination match. Explicit per-model lists, including empty arrays, and explicit provider-wide lists are preserved. Unknown models retain the preset's default policy.
Refs #4308. This fixes missing destination metadata independently of the already-landed #4282 table row. It does not change provider identity, routing, OAuth matching or unrelated capability axes. Regression coverage follows gathered rows into DSH and ZCode exports.
Verification
Checklist