Capitalise analysis results in source strings instead of CSS #16731
+24
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
New keys introduced; the existing keys will be retained in /translation/source until Crowdin pre-translation is complete. The old keys should be deleted only after the pre-translations have been pulled into master.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Capitalised the first three entries of the computer analysis results table in source strings instead of through CSS, per discussion in #16649.
In the absence of a convention, I changed
nbFootonumberFoofor the new strings. The key must be different, and I hope this is a suitable substitute.translation/source. Crowdin is only concerned with thetranslationfolder, which is why I think it's safe to remove the corresponding entries for the old keys ini18n.d.tsandkey.scala.Once pulled, this commit will enable me to run pre-translation on the Crowdin side for the new string.
At that point, I can make a separate commit to remove the old strings.