-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
aaarmstark's pinned streamer image link #16623
Merged
ornicar
merged 8 commits into
lichess-org:master
from
schlawg:relay-pinned-streamer-image-link
Dec 22, 2024
Merged
aaarmstark's pinned streamer image link #16623
ornicar
merged 8 commits into
lichess-org:master
from
schlawg:relay-pinned-streamer-image-link
Dec 22, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
supersedes #16589, which looked like: |
argh, youtube play button is trademarked. |
ornicar
reviewed
Dec 22, 2024
.add("pinned" -> pinned.map: p => | ||
Json | ||
.obj("name" -> p.name) | ||
.add("redirect" -> p.upstream.map(_.urls(lila.core.config.NetDomain("")).redirect)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NetDomain("") 😒
This was referenced Dec 22, 2024
ornicar
added a commit
that referenced
this pull request
Dec 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[edit] removed version with youtube play button
Screen.Recording.2024-12-21.at.16.55.09.mov