Translate board menu in puzzle and game #16551
Conversation
modules/coreI18n/src/main/key.scala
Outdated
| @@ -1134,6 +1133,9 @@ object I18nKey: | |||
| val `notifyWeb`: I18nKey = "preferences:notifyWeb" | |||
| val `notifyDevice`: I18nKey = "preferences:notifyDevice" | |||
| val `bellNotificationSound`: I18nKey = "preferences:bellNotificationSound" | |||
| val `blindFold`: I18nKey = "preferences:blindFold" | |||
| val `voiceInput`: I18nKey = "preferences:voiceInput" | |||
There was a problem hiding this comment.
a translation already exists, inputMovesWithVoice
modules/coreI18n/src/main/key.scala
Outdated
| @@ -1134,6 +1133,9 @@ object I18nKey: | |||
| val `notifyWeb`: I18nKey = "preferences:notifyWeb" | |||
| val `notifyDevice`: I18nKey = "preferences:notifyDevice" | |||
| val `bellNotificationSound`: I18nKey = "preferences:bellNotificationSound" | |||
| val `blindFold`: I18nKey = "preferences:blindFold" | |||
There was a problem hiding this comment.
why the capital F? Everywhere else it's just blindfold
modules/coreI18n/src/main/key.scala
Outdated
| @@ -1134,6 +1133,9 @@ object I18nKey: | |||
| val `notifyWeb`: I18nKey = "preferences:notifyWeb" | |||
| val `notifyDevice`: I18nKey = "preferences:notifyDevice" | |||
| val `bellNotificationSound`: I18nKey = "preferences:bellNotificationSound" | |||
| val `blindFold`: I18nKey = "preferences:blindFold" | |||
| val `voiceInput`: I18nKey = "preferences:voiceInput" | |||
| val `keyboardInput`: I18nKey = "preferences:keyboardInput" | |||
There was a problem hiding this comment.
a translation already exists, inputMovesWithTheKeyboard
|
The text of the translations for the preferences may be too long to fit the side view ... There are a few options:
|
|
I wish to highlight that we already have the string I don't believe Lila has a mechanism to use the app's translations. With that in mind, I can migrate the translations from the mobile side using Crowdin pre-translation if you are happy with that? We can then delete the key on that side to avoid duplicating effort. |
|
Thanks for the vote of confidence, Thibault. I have copied all translations using Crowdin pre-translation from the mobile app to lila's file, and created an issue #1259 for the mobile app to replace their string with lila's. Edit, 2024-12-12: The string has now been wholly replaced ok the mobile side. |
Note that I have used 2 translations from preferences (which are the titles of the preference pages)
'Game display preferences' becomes 'Display' (i18n.preferences.display)
'Game behavior preferences' becomes 'Game behavior' (i18n.preferences.gameBehavior)
If you prefer, I can add 2 specific keys
Puzzle board menu:
Game board menu: