stop collecting zombie HTMLDialogElements

fix #16900
lichess-org · Feb 13, 2025 · 20d3562 · 20d3562
1 parent b1f660c
commit 20d3562
Showing 1 changed file with 10 additions and 2 deletions.
diff --git a/ui/analyse/src/study/chapterNewForm.ts b/ui/analyse/src/study/chapterNewForm.ts
@@ -1,6 +1,6 @@
 import { parseFen } from 'chessops/fen';
 import { defined, prop, type Prop, toggle } from 'common';
-import { snabDialog, alert } from 'common/dialog';
+import { type Dialog, snabDialog, alert } from 'common/dialog';
 import * as licon from 'common/licon';
 import { bind, bindSubmit, onInsert, looseH as h, dataIcon, type VNode } from 'common/snabbdom';
 import { storedProp } from 'common/storage';
@@ -29,7 +29,10 @@ export const fieldValue = (e: Event, id: string) =>
 export class StudyChapterNewForm {
   readonly multiPgnMax = 64;
   variants: Variant[] = [];
-  isOpen = toggle(false);
+  dialog: Dialog | undefined;
+  isOpen = toggle(false, val => {
+    if (!val) this.dialog?.close();
+  });
   initial = toggle(false);
   tab = storedProp<ChapterTab>(
     'analyse.study.form.tab',
@@ -142,11 +145,16 @@ export function view(ctrl: StudyChapterNewForm): VNode {
   return snabDialog({
     class: 'chapter-new',
     onClose() {
+      ctrl.dialog = undefined;
       ctrl.isOpen(false);
       ctrl.redraw();
     },
     modal: true,
     noClickAway: true,
+    onInsert: dlg => {
+      ctrl.dialog = dlg;
+      dlg.show();
+    },
     vnodes: [
       activeTab !== 'edit' &&
         h('h2', [