Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Fix benchmark triggers #1011

Merged
merged 2 commits into from
Feb 11, 2025
Merged

[CI] Fix benchmark triggers #1011

merged 2 commits into from
Feb 11, 2025

Conversation

rengolin
Copy link
Contributor

This fixes both workflow_dispatch, now with check-boxes instead of integers and actually running correctly, as well as pull_request that now doesn't need to remove/add the benchmark label every time you update the PR.

This fixes both `workflow_dispatch`, now with check-boxes instead of integers and actually running correctly, as well as `pull_request` that now doesn't need to remove/add the `benchmark` label every time you update the PR.
@rengolin rengolin added the benchmark Benchmark base targets label Feb 10, 2025
@rengolin
Copy link
Contributor Author

Ok, PR updated after adding the label and I did not need to remove/add to re-run the benchmarks. Seems to be working.

@adam-smnk
Copy link
Contributor

What's the new behavior? Does it dispatch benchmarks on all PRs automatically or only after labeling but without the need to reapply label afterwards?

@rengolin
Copy link
Contributor Author

rengolin commented Feb 11, 2025

What's the new behavior? Does it dispatch benchmarks on all PRs automatically or only after labeling but without the need to reapply label afterwards?

It always dispatches the benchmarks on every PR, but they don't run of the label is not there, so they show as "skipped".

Once applied, the label will trigger the check and when the benchmarks run again on update, the check will succeed and they won't be skipped.

the only problem now is that any update on a PR will run the benchmarks. I'm trying to find the right set of actions that will only update on rebase / reopen / label. but at least comments don't trigger, only updating the title/description, so not critical now and better than before.

Copy link
Contributor

@adam-smnk adam-smnk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine, let's take it for a spin and see how it goes in practice

@rengolin rengolin merged commit bac688f into libxsmm:main Feb 11, 2025
14 checks passed
@rengolin rengolin deleted the actions branch February 11, 2025 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
benchmark Benchmark base targets
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants