-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump libxsmm #1000
Bump libxsmm #1000
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@alheinecke Rerunning benchmark again but I see regressions on baseline |
Nothing changed in libxsmm-dnn. Which one regress? |
BASE: MLIR models look fine with no change. |
Oh... the libxsmm-dnn commit was so old and our benchmarks are not meaningful as we discussed a couple of month back.... (for both libxsmm-dnn and MLIR). libxsmm-dnn uses now (6 months ago commit) by default SFC and this hurts the tiny test we are running as it causes more cache to cache transfers. There are now two options: a) defining more reasonable benchmarks b) disabling SFC in libxsmm by exporting LIBXSMM_DNN_DISABLE_SFC=1 |
Alright, I'll try the env var just for consistency and we should revisit benchmarks separately altogether. |
|
Anyway, it's not a blocker as MLIR execution is unaffected. |
I guess it might be also related to argument changes in libxsmm-dnn (flat layouts vs, packed). It's nearly a 1 year bump.... |
we can also only bump libxsmm and not libxsmm-dnn... |
This reverts commit 0ea7628.
Yup, just bumping libxsmm. No regressions in benchmarks. |
No description provided.