Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump libxsmm #1000

Merged
merged 4 commits into from
Jan 10, 2025
Merged

Bump libxsmm #1000

merged 4 commits into from
Jan 10, 2025

Conversation

adam-smnk
Copy link
Contributor

No description provided.

@adam-smnk adam-smnk added benchmark Benchmark base targets and removed benchmark Benchmark base targets labels Jan 10, 2025
Copy link
Contributor

@alheinecke alheinecke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adam-smnk
Copy link
Contributor Author

@alheinecke Rerunning benchmark again but I see regressions on baseline xsmm_dnn_mlp performance.

@alheinecke
Copy link
Contributor

Nothing changed in libxsmm-dnn. Which one regress?

@adam-smnk
Copy link
Contributor Author

Nothing changed in libxsmm-dnn. Which one regress?

BASE: gemm_f32_dnn_target, gemm_bf16_dnn_target, mlp_f32_dnn_target, mlp_bf16_dnn_target
And all their OMP f32 and bf16 counterparts e.g., gemm_bf16_omp_2_dnn

MLIR models look fine with no change.

@alheinecke
Copy link
Contributor

Oh... the libxsmm-dnn commit was so old and our benchmarks are not meaningful as we discussed a couple of month back.... (for both libxsmm-dnn and MLIR). libxsmm-dnn uses now (6 months ago commit) by default SFC and this hurts the tiny test we are running as it causes more cache to cache transfers. There are now two options: a) defining more reasonable benchmarks b) disabling SFC in libxsmm by exporting LIBXSMM_DNN_DISABLE_SFC=1

@adam-smnk
Copy link
Contributor Author

Alright, I'll try the env var just for consistency and we should revisit benchmarks separately altogether.

@adam-smnk adam-smnk added benchmark Benchmark base targets and removed benchmark Benchmark base targets labels Jan 10, 2025
@adam-smnk
Copy link
Contributor Author

LIBXSMM_DNN_DISABLE_SFC=1 somewhat improved bf16 but fp32 is still much worse than before.

@adam-smnk
Copy link
Contributor Author

Anyway, it's not a blocker as MLIR execution is unaffected.
Let's merge for now and we can revisit these settings later.

@alheinecke
Copy link
Contributor

I guess it might be also related to argument changes in libxsmm-dnn (flat layouts vs, packed). It's nearly a 1 year bump....

@alheinecke
Copy link
Contributor

we can also only bump libxsmm and not libxsmm-dnn...

@adam-smnk adam-smnk changed the title Bump libxsmm and libxsmm-dnn Bump libxsmm Jan 10, 2025
@adam-smnk adam-smnk added benchmark Benchmark base targets and removed benchmark Benchmark base targets labels Jan 10, 2025
@adam-smnk
Copy link
Contributor Author

we can also only bump libxsmm and not libxsmm-dnn...

Yup, just bumping libxsmm. No regressions in benchmarks.

@adam-smnk adam-smnk merged commit 7e6b24d into libxsmm:main Jan 10, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
benchmark Benchmark base targets
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants