Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GPU: Fix validation warning in D3D12 blit code #11559

Merged
merged 1 commit into from
Dec 4, 2024
Merged

GPU: Fix validation warning in D3D12 blit code #11559

merged 1 commit into from
Dec 4, 2024
+1 −1

Conversation

lmurray
Copy link
Contributor

@lmurray lmurray commented Dec 1, 2024

Fixes the following D3D12 debug layer warnings:

D3D12 WARNING: ID3D12Device::CreateSampler2: ComparisonFunc is D3D12_COMPARISON_FUNC_ALWAYS, but D3D12_FILTER_MIN_MAG_MIP_POINT is not a comparison filter. This is OK, as the ComparisonFunc will simply be ignored, but is was likely not the intent. [ STATE_CREATION WARNING #1361: CREATE_SAMPLER_COMPARISON_FUNC_IGNORED]
D3D12 WARNING: ID3D12Device::CreateSampler2: ComparisonFunc is D3D12_COMPARISON_FUNC_ALWAYS, but D3D12_FILTER_MIN_MAG_MIP_LINEAR is not a comparison filter. This is OK, as the ComparisonFunc will simply be ignored, but is was likely not the intent. [ STATE_CREATION WARNING #1361: CREATE_SAMPLER_COMPARISON_FUNC_IGNORED]

@slouken slouken added this to the 3.2.0 milestone Dec 3, 2024
@slouken slouken merged commit efb59bd into libsdl-org:main Dec 4, 2024
40 checks passed
@slouken
Copy link
Collaborator

slouken commented Dec 4, 2024

Merged, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thatcosmonaut thatcosmonaut thatcosmonaut approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.2.0
Development

Successfully merging this pull request may close these issues.
3 participants
@lmurray @slouken @thatcosmonaut