Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wayland message box: improve zenity argument handling #11408

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Wayland message box: improve zenity argument handling #11408

wants to merge 2 commits into from

Commits on Nov 21, 2024

  1. wayland: handle 0 extra buttons in message box 

    When no extra buttons are passed to zenity with `--question --switch`
arguments it fails to show anything, however, SDL3 still reports
success. To handle this case, we pass an additional "OK" button.
    @marcin-serwin
    marcin-serwin committed Nov 21, 2024
    Configuration menu
    Copy the full SHA
    b696c24 View commit details
    Browse the repository at this point in the history

  2. wayland: pass actual empty strings to zenity 

    The double quotes were passed literally to the zenity arguments which
resulted in the message box displaying literal `""` when no text was
given. The empty string is more logical in this case, e.g., the empty
title results in the message box having lesser height.
    @marcin-serwin
    marcin-serwin committed Nov 21, 2024
    Configuration menu
    Copy the full SHA
    65c7d16 View commit details
    Browse the repository at this point in the history