Add SDL_ShowFileDialogWithProperties with some more options #11170
+589
−287
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
--attach
option. The only issue is that it supports only X11, so no Wayland support still.While deciding the names of the properties, I noticed that some boolean properties are typed as
SDL_PROP_..._BOOL
and others asSDL_PROP_..._BOOLEAN
(RIP about the ABI freeze). I followed the second format, which seems to be more common.Existing Issue(s)
Closes #11133
I'd like to commend the only platform that supports every dialog option: Haiku (!). A close second is Zenity (!!), which managed to find the way to support everything as well, even modal dialogs, but only partially because it lacks Wayland support so I count it as half a point. Every other platform lacks at least one option completely: macOS and XDG Portals don't allow labeling the cancel button, Windows doesn't (I believe) allow labeling either button, and Android neither buttons nor dialog title, and no folder support at all as well (though those are probably not just relevant to the platform).