Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue #1874. #1876

Closed
wants to merge 3 commits into from
Closed

Fix issue #1874. #1876

wants to merge 3 commits into from

Conversation

ShigeakiAsai
Copy link
Contributor

Pull requests

This pull request is for issue #1874.

I think this issue concerns to "Update all lakka packages Retroach latest + cores"(5b413c99f6452db02c889b1018c91660876a41f8)"'s commit.

I was checking commit history in following package.
PKG_NAME="retroarch_joypad_autoconfig"
PKG_SITE="https://github.com/libretro/retroarch-joypad-autoconfig"

Target version is latest commit(5666e46bb89caf4e9af358fdb97a2b384cb62f36).
But, previous commit(ccd5bd3820969e1236f6eb32f90ed2f7d95ca06f) conteins filename changing.
From "bare" to "old".

Therefore, I thnk it needs to change to replaced filename in package.mk

  • packages/lakka/retroarch_base/retroarch_joypad_autoconfig/package.mk

Thanks,
ASAI, Shigeaki

@ShigeakiAsai
Copy link
Contributor Author

BTW, I met 4 build fails on the following projects.

  • same_cdi
  • vice
  • stella
  • mame

I'm sorry for being not able to report yet about above build fails.
Now, I'm reading the contribution rule.

My build environment is bellow.
OS: Ubuntu 22.04.3 LTS (GNU/Linux 5.15.90.1-microsoft-standard-WSL2 x86_64) on Windows 11 WSL
Branch: Lakka-v5.x
Commit: dc34f7a
Build command: DISTRO=Lakka PROJECT=RPi DEVICE=RPi4 ARCH=aarch64 make image

Sorry for my poor English.
ASAI, Shigeaki

@ShigeakiAsai
Copy link
Contributor Author

I confirmed that the same commit was merged as d47fc01.

Thank you.
ASAI, Shigeaki

@ShigeakiAsai ShigeakiAsai deleted the forissue1874 branch September 5, 2023 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant