-
-
Notifications
You must be signed in to change notification settings - Fork 40
Improve C89 compliance and code standards #93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jcarr71
wants to merge
43
commits into
libretro:master
Choose a base branch
from
jcarr71:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit introduces the implementation of stb_image functions in a new source file, stb_image_impl.c. This file includes the necessary definitions to enable the functionality provided by the stb_image library. Only one C file should define STB_IMAGE_IMPLEMENTATION to avoid multiple definitions.
- Added comprehensive technical overview and visual reference documentation for the file browser feature. - Added support for various platforms, ensuring consistent behavior across Windows, Linux, macOS, Android, Switch, and Vita. - Included error handling strategies and performance considerations for efficient operation. - Updated build configurations to include new source files for different architectures (arm64-v8a, armeabi-v7a, riscv64, x86, x86_64).
- Created dependency files for various source files including cart.c, controller.c, cp1610.c, and others. - Updated dependencies for libretro-common components such as compat_posix_string.c, compat_snprintf.c, and file_path.c. - Included necessary headers for each source file to ensure proper compilation. - Enhanced project structure by organizing object files and their dependencies for better build management.
Added images and updated contributors section in README.
Added Ko-fi username for funding support.
… a 'core option'.
…for change to core option from separate core
…splay instructions
…splay name, supported extensions, and description
- Implement side-by-side dual-screen rendering (1074×600 workspace) - Add touchscreen hotspot input detection for 12 keypad buttons - Support ROM-specific PNG overlays (370×600 pixels) - Add cross-platform input handling (Android, Windows, Linux) - Include screen swap functionality - Update documentation with setup and usage instructions - Update core metadata and info file - Remove debug logging infrastructure - Maintain full backward compatibility
…erlays Add Dual-Screen Touchscreen and Overlay Support to FreeIntv Core
…ced onscreen interactive keypad overlays and improved versioning
…n default single screen mode.
…creen/mouse are required.
Contributor
|
Can you solve the branch conflict? |
Contributor
Author
Done! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR improves code standards compliance and maintainability:
Changes
C89 Compliance
//) to C89 style (/* */)Code Quality
Build Status
✅ Clean build successful - no errors, only minor -Wshadow warnings
Testing
Notes
This PR follows on from the previously merged multi-screen overlay feature (PR #92) and provides code standards improvements to the codebase.