Skip to content

Conversation

@BlazeEntertainment
Copy link

  • Added Game specific mappings. In games like Night Stalker, you need to use the keypad to fire the weapon which is near impossible when using a keypad or keyboard. So wrote up specific key mappings to face buttons that make sense.
  • Added XBOX style controller prompts to in game menu. A simple ifdef that can be enabled to flip the face buttons if the device uses XBOX style face button layouts instead of RetroPad
  • Upped version to 1.2, because we added savestates and overhauled a number of elements and fixed a number of graphical, sound and accuracy issues ontop of the WIP mappings.

Todo

  • Some games won't work well with modern game controllers without a keypad. These games have been remapped to facebuttons to be functional like Night Stalker, however these fixes are currently achieved with #IFDEF's. Need to replace these IFDEFS with some form of decent game detection so it automatically sets these new mappings.

BlazeEntertainment and others added 5 commits June 15, 2021 14:41
TODO:
- Check audio (partly unserialized)
- Check cart interaction after state load (missing serialization of pos etc)
- Use fixed size Integer types for safe cross platform use
- Maybe serialize the frame contents & scanline states
@markwkidd
Copy link
Contributor

markwkidd commented Jul 1, 2021 via email

@BlazeEntertainment BlazeEntertainment changed the title [WIP] Add game specific mappings to suit gamepads, Add XBox style controll layout, Upped version [WIP DRAFT] Add game specific mappings to suit gamepads, Add XBox style controll layout, Upped version Jul 2, 2021
@BlazeEntertainment
Copy link
Author

Appologies @markwkidd, I worded the MR extremely badly. I messaged you in person however please ignore this commit for now as upon reflection I want to reword some of these changes to make more sense and add some of the menu layout changes as a Core Option instead of an ifdef.

@inactive123
Copy link
Contributor

I will have to think some more about this. I think it'd be a fundamental mistake to start dirtying up the codebase with all sorts of ifdefs for certain controllers. Best there is some libretro API extension instead to accomodate something like that. Anyway, we have to put this on hold for now until we can internally think of some solution.

[WIP] Minimal working Savestates
@lgtm-com
Copy link

lgtm-com bot commented Jul 19, 2021

This pull request fixes 3 alerts when merging a18e0b1 into 5fc8d85 - view on LGTM.com

fixed alerts:

  • 3 for Short global name

@lgtm-com
Copy link

lgtm-com bot commented Jul 21, 2021

This pull request fixes 4 alerts when merging 87fe95e into 5fc8d85 - view on LGTM.com

fixed alerts:

  • 4 for Short global name

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants