-
Notifications
You must be signed in to change notification settings - Fork 26
WHL: upgrade cibuildwheel to 3.0.0 (OpenAstronomy/github-actions-workflows
v2.0.0)
#168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WHL: upgrade cibuildwheel to 3.0.0 (OpenAstronomy/github-actions-workflows
v2.0.0)
#168
Conversation
229df9a
to
250d0de
Compare
Looks like the wheel-building workflow was automatically disabled, which defeats the purpose of this PR. |
@neutrinoceros - I'm trying to parse the workflows, but I actually do not understand why the wheel-building is not run, nor know how to enable it. Let me ping @astrofrog, who I think implemented it (and who certainly understands github actions better). |
Nevermind, it seems to be activated already (thanks to @avalentino, I suppose !). Let me just power cycle this PR, and bump to beta2 while I'm at it. |
250d0de
to
dfe5e56
Compare
This seems to be going well, so the upgrade should be trivial when the stable release is out. |
dfe5e56
to
9a4bdfd
Compare
OpenAstronomy/github-actions-workflows
v2.0.0)
undrafting now that cibuildwheel 3.0.0 is out |
9a4bdfd
to
76715cb
Compare
Whoops, got a build error on windows and no time to fix it right now, sorry about the noise. I'll try to circle back to it later today ! |
Actually this failure is unrelated and reproduced in #170 |
Got it, the bug is in Python 3.13.4 itself, and fixed in 3.14.5, which should be available on GHA in a matter of minutes to hours: |
Thanks @neutrinoceros |
testing out OpenAstronomy/github-actions-workflows#278, and adjusting settings:
pypy builds are now disabled by default, and
pp39
requiresenable: pypy-eol
, which I think is a sign that we should start building against more recent versions of pypy instead, though, for the time being, I'm doing a simple dependency upgrade with no observable change.