Skip to content

WHL: upgrade cibuildwheel to 3.0.0 (OpenAstronomy/github-actions-workflows v2.0.0) #168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

neutrinoceros
Copy link
Contributor

testing out OpenAstronomy/github-actions-workflows#278, and adjusting settings:
pypy builds are now disabled by default, and pp39 requires enable: pypy-eol, which I think is a sign that we should start building against more recent versions of pypy instead, though, for the time being, I'm doing a simple dependency upgrade with no observable change.

@neutrinoceros neutrinoceros force-pushed the whl/exp/try-out-cibw-3.0.0b1 branch from 229df9a to 250d0de Compare May 19, 2025 19:09
@neutrinoceros
Copy link
Contributor Author

Looks like the wheel-building workflow was automatically disabled, which defeats the purpose of this PR.
Could @mhvk or @avalentino turn it back on ?

@mhvk
Copy link
Contributor

mhvk commented May 26, 2025

@neutrinoceros - I'm trying to parse the workflows, but I actually do not understand why the wheel-building is not run, nor know how to enable it. Let me ping @astrofrog, who I think implemented it (and who certainly understands github actions better).

@neutrinoceros
Copy link
Contributor Author

Nevermind, it seems to be activated already (thanks to @avalentino, I suppose !). Let me just power cycle this PR, and bump to beta2 while I'm at it.

@neutrinoceros neutrinoceros force-pushed the whl/exp/try-out-cibw-3.0.0b1 branch from 250d0de to dfe5e56 Compare May 26, 2025 15:41
@neutrinoceros neutrinoceros changed the title WHL(EXP): test cibuildwheel 3.0.0b1 WHL(EXP): test cibuildwheel 3.0.0b2 May 26, 2025
@neutrinoceros
Copy link
Contributor Author

This seems to be going well, so the upgrade should be trivial when the stable release is out.
What do you think about upgrading PyPy wheels to pp310 ? this version has been available for almost 2 years and doesn't seem about to get away anytime soon. I could do this in a separate PR.

@neutrinoceros neutrinoceros force-pushed the whl/exp/try-out-cibw-3.0.0b1 branch from dfe5e56 to 9a4bdfd Compare June 12, 2025 10:24
@neutrinoceros neutrinoceros changed the title WHL(EXP): test cibuildwheel 3.0.0b2 WHL: upgrade cibuildwheel to 3.0.0 (OpenAstronomy/github-actions-workflows v2.0.0) Jun 12, 2025
@neutrinoceros
Copy link
Contributor Author

undrafting now that cibuildwheel 3.0.0 is out
Ping @mhvk

@neutrinoceros neutrinoceros marked this pull request as ready for review June 12, 2025 10:25
@neutrinoceros neutrinoceros force-pushed the whl/exp/try-out-cibw-3.0.0b1 branch from 9a4bdfd to 76715cb Compare June 12, 2025 10:26
@neutrinoceros
Copy link
Contributor Author

Whoops, got a build error on windows and no time to fix it right now, sorry about the noise. I'll try to circle back to it later today !

@neutrinoceros neutrinoceros marked this pull request as draft June 12, 2025 10:31
@neutrinoceros
Copy link
Contributor Author

Actually this failure is unrelated and reproduced in #170

@neutrinoceros neutrinoceros marked this pull request as ready for review June 12, 2025 17:14
@neutrinoceros
Copy link
Contributor Author

neutrinoceros commented Jun 12, 2025

Got it, the bug is in Python 3.13.4 itself, and fixed in 3.14.5, which should be available on GHA in a matter of minutes to hours:
xref python/cpython#135151
xref actions/python-versions#344

@avalentino avalentino merged commit 3761e78 into liberfa:main Jul 2, 2025
42 of 44 checks passed
@avalentino
Copy link
Member

Thanks @neutrinoceros

@neutrinoceros neutrinoceros deleted the whl/exp/try-out-cibw-3.0.0b1 branch July 2, 2025 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants