-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add: separate mod for xdp #625
Conversation
Will take a look by Wednesday the latest. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your pull request! Your change seems mostly fine. I left a few comments. I think we should think about adding more tests. Specifically, for
- query()
- forced errors for attach(), detach(), query() and query_id()
- double attach() & detach() (second one should fail, I would expect)?
What do you think?
bf8fc85
to
3252fd5
Compare
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for updating! I left a few more comments regarding the API. Looking closer at it I think there are some cases that we want to support but do not currently. Let me know what you think.
I think error handling for these functions is broken currently. Don't know if that will change much, though. |
15b61ba
to
fc02f68
Compare
Signed-off-by: yogaraj.s <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems okay. Thanks.
Add a CHANGELOG entry for #625 and fix up various minor details. Signed-off-by: Daniel Müller <[email protected]>
@danielocfb Can you please release a build for this? |
Hi @syogaraj , we just released |
We really need this support in the libbpf-rs for our use case. Can we expect the release in a week? Asking to avoid manually building it from source and use them. |
We can publish a new release this week. |
FYI, I just pushed 0.22.1. |
Thank you so much! |
XDP-related operations are now added as a separate mod as discussed in #618
Closes:
#618
#205
#206
#263