Backport fix for deriving public keys from private ones to version3
#1627
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
April 1, 2025 15:31
In case `hd_private` is invalid, the `to_public()` derivation
should fail. The `hd_private` might be invalid from various reasons,
such as deserializing invalid key or derived, using `derive_private`
into an invalid one.
Finally, nitpick: `return {};` is enclosed in curly brackets to make the
if statement scope explicit.
|
The 4th segment of the name is the test expectation. Whatever the test expects to happen. https://github.com/libbitcoin/libbitcoin-system/wiki/Test-Guide |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a backport of a bug fix to
version3. More details are available in #1623 and #1624.The fix is the same, also the tests were just copy-pasted. I've also split the tests into the respective files.
However, I am a bit unclear on the test naming. What is
expectedsuffix supposed to mean?