refactor: reduce throwing errors #234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MH4GF
temporarily deployed
to
preview - erd-sample
GitHub Actions
Inactive
MH4GF
commented
Dec 12, 2024
| if (node instanceof StringNode) return node.unescaped.value | ||
| return '' | ||
| }, | ||
| ) as [string, string] |
There was a problem hiding this comment.
An as cast was required here, because TypeScript cannot infer that it is a tuple of strings.
MH4GF
commented
Dec 12, 2024
| } catch (error) { | ||
| throw new Error( | ||
| `Failed to parse ${format} file: ${error instanceof Error ? error.message : String(error)}`, | ||
| ) |
There was a problem hiding this comment.
One of the main motivations was to remove try-catch here.
MH4GF
requested review from
hoshinotsuyoshi,
FunamaYukina,
junkisai and
sasamuku
and removed request for
a team
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stop throwing errors and return the error class to the caller.
This makes it easier to take error handling into account on the CLI side. For example, adjusting the log level.