Repository navigation
chore(tests): apply gopls modernize hints in tests - #175
Merged
Merged
Conversation
lexfrei
force-pushed
the
chore/test-modernize
branch
from
October 8, 2026 20:14
37bbcf8 to
d688d94
Compare
Container image availableMulti-arch image (amd64 + arm64): podman pull ttl.sh/extractedprism:pr-175-1d
|
Use t.Context() for run contexts that are only canceled by test teardown, and drop spelled-out embedded types (ObjectMeta in EndpointSlice literals, TLSClientConfig in rest.Config) from struct literals. No assertions change. Assisted-by: LLM Signed-off-by: Aleksei Sviridkin <f@lex.la>
lexfrei
force-pushed
the
chore/test-modernize
branch
from
October 8, 2026 21:25
d688d94 to
4e49437
Compare
lexfrei
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Applies the open gopls modernize hints in the server and Kubernetes discovery tests. Tests that only canceled their run context through
defer cancel()now uset.Context(), and struct literals no longer spell out embedded types such asObjectMetainEndpointSliceandTLSClientConfiginrest.Config. No assertions change.gopls checkreports no hints for these files now. The server and discovery packages pass under--raceand repeated runs on Linux.Closes #171