Merged
Conversation
- Guard SafeGetString against undefined JsonElement (ValueKind check) - Add -v q to dotnet run in test helpers to suppress build output leaking into stdout, which corrupted JSON parsing in tests Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Detect and load skill-validator databases (from dotnet/skills#149) alongside existing Copilot CLI session-store.db files. The --db flag now accepts either database type, auto-detected via schema_info vs schema_version tables. Changes: - Add SessionDbType enum and BrowserSession record to replace tuple - Add DetectDbType() for schema-based DB type detection - Add LoadSkillValidatorSessions() with config_dir relative path resolution - Show eval metadata (metrics, judge, pairwise) in preview panel - Adapt browser icons and display for skill-validator sessions - Handle sessions without events.jsonl gracefully Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Normalize Windows backslashes in config_dir for Linux/WSL compatibility. Search nested session-state/<guid>/events.jsonl when direct path not found. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Try standalone 'copilot' first, fall back to 'gh copilot' for users who installed via the GitHub CLI extension. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add support for browsing skill-validator evaluation databases (dotnet/skills#149) alongside existing Copilot CLI
session-store.dbfiles.The
--dbflag now auto-detects the database type via schema inspection (schema_infotable for skill-validator vsschema_versionfor Copilot CLI) and adapts the browser accordingly.Changes
Models.cs: AddSessionDbTypeenum andBrowserSessionrecord to replace the 8-field value tuple, with optional eval-specific fields (SkillName, ScenarioName, Role, Model, Status, Prompt, MetricsJson, JudgeJson, PairwiseJson)SessionBrowser.cs:DetectDbType()— inspects schema tables to distinguish DB typesLoadSkillValidatorSessions()— reads skill-validator schema, joinssessions+run_results, resolvesconfig_dirrelative to DB directoryskill: scenario (role) [model]display formatevents.jsonlis missing (opens preview instead)replay.cs: Updated help text for--dbflagtests/DbPathTests.cs: Updated help text assertionUsage
Testing
All 67 existing tests pass. Integration tests require a skill-validator
sessions.dbfile (tracked as follow-up).