Skip to content

Conversation

@b7g
Copy link
Contributor

@b7g b7g commented Nov 3, 2023

Description

Converted the project to the Godot 4.1 version (4.1.2)
This is a work in progress, open for participation.
In it's current state it breaks all games, but snake.

Checklist

  • My code follows the general style guidelines of the project
  • I have perfomed a self-review of my code
  • I have commented my code, particulary where it is unclear
  • My changes generate no new warnings or errors
  • The project compiles and runs correctly

@Joshix-1
Copy link
Contributor

Joshix-1 commented Nov 4, 2023

you need to update the Godot version in the Earthfile

@ASecondGuy
Copy link
Contributor

Not sure if we should port to Godot 4 but if we do now would be the best moment when nobody is working on anything else.

@b7g
Copy link
Contributor Author

b7g commented Nov 4, 2023

Well, that did not work out. Who can fix the build/lint workflows?

# Install godot-gdscript-toolkit
- name: Install godot-gdscript-toolkit
run: pip3 install 'gdtoolkit==3.*'
run: pip3 install 'gdtoolkit==4.*'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it seems like you need to also install setuptools since python 3.12, we should pin the python version, so this doesn't happen again.

      - name: Setup Python
        uses: actions/setup-python@v4
        with:
          python-version: 3.12
      - name: Install setuptools
        run: pip3 install setuptools
      # Install godot-gdscript-toolkit
      - name: Install godot-gdscript-toolkit
        run: pip3 install 'gdtoolkit==4.*'

@Joshix-1
Copy link
Contributor

Joshix-1 commented Nov 4, 2023

I don't know how to fix the build. The error message is weird. I don't know earthfile stuff

@Joshix-1
Copy link
Contributor

Joshix-1 commented Nov 4, 2023

changed the build completly without earthly, that seems to work: 6275bfe

@BjoernAkAManf
Copy link
Contributor

Related statement missing

Which is stated quite clearly in the logs. Annoying yes, but given thhat it kept workiing till now is quite nice.

Don't have a preference either way though :)

@b7g
Copy link
Contributor Author

b7g commented Nov 5, 2023

Now that looks good, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants