-
Notifications
You must be signed in to change notification settings - Fork 20
Godot 4.1 conversion #95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
you need to update the Godot version in the Earthfile |
|
Not sure if we should port to Godot 4 but if we do now would be the best moment when nobody is working on anything else. |
|
Well, that did not work out. Who can fix the build/lint workflows? |
| # Install godot-gdscript-toolkit | ||
| - name: Install godot-gdscript-toolkit | ||
| run: pip3 install 'gdtoolkit==3.*' | ||
| run: pip3 install 'gdtoolkit==4.*' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it seems like you need to also install setuptools since python 3.12, we should pin the python version, so this doesn't happen again.
- name: Setup Python
uses: actions/setup-python@v4
with:
python-version: 3.12
- name: Install setuptools
run: pip3 install setuptools
# Install godot-gdscript-toolkit
- name: Install godot-gdscript-toolkit
run: pip3 install 'gdtoolkit==4.*'|
I don't know how to fix the build. The error message is weird. I don't know earthfile stuff |
|
changed the build completly without earthly, that seems to work: 6275bfe |
|
Which is stated quite clearly in the logs. Annoying yes, but given thhat it kept workiing till now is quite nice. Don't have a preference either way though :) |
|
Now that looks good, thanks. |
Description
Converted the project to the Godot 4.1 version (4.1.2)
This is a work in progress, open for participation.
In it's current state it breaks all games, but snake.
Checklist