ratelimits: Refactor Reset() to accept a batch of Transactions #8503
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beautifulentropy
force-pushed
the
make-resets-take-transactions
branch
from
c9297b0 to
f4ec6cd
Compare
beautifulentropy
changed the title
Member
Author
|
I am satisfied that all keys will be deleted even if some are missing. |
jprenken
previously approved these changes
Nov 21, 2025
aarongable
reviewed
Nov 22, 2025
| func (r *RedisSource) Delete(ctx context.Context, bucketKey string) error { | ||
| // BatchDelete deletes the TATs at the specified bucketKeys ('name:id'). A nil | ||
| // return value does not indicate that the bucketKeys existed. | ||
| func (r *RedisSource) BatchDelete(ctx context.Context, bucketKeys []string) error { |
Contributor
There was a problem hiding this comment.
Can't BatchDelete and Delete just be a single function with variadic args?
func (r *RedisSource) Delete(ctx context.Context, bucketKeys ...string) error {
Member
Author
There was a problem hiding this comment.
Actually, I’m just going to remove Delete(). I had a caller for it originally, but I removed that and forgot to drop the implementation. As for switching from []string to a variadic, it doesn’t feel consistent unless BatchGet() changes too, and modifying the Source interface that much doesn’t seem worthwhile unless there’s a compelling reason I’m missing??
jprenken
approved these changes
Nov 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8305