feat: synchronize file name#6
Open
edabe wants to merge 4 commits into
Open
Conversation
Owner
|
Thanks for the clear feature write-up. The rename behavior makes sense; I think this PR is close, but it needs a small readiness pass before it is safe to merge. Minimum fixes:
I verified |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Synchronizes file name to either match the new pattern, or when the note title in Plaud has changed.
How it works:
When syncing with "Update existing notes" enabled:
file_idin frontmatterChanges made:
src/plaud-vault.ts:
rename()method toPlaudVaultAdapterinterface'renamed'action type toUpsertPlaudNoteResultoldPathfield to track the previous filenameupsertPlaudNote()to compare current filename with desired filename and rename if differentsrc/main.ts:
rename()method in vault adapter using Obsidian'svault.rename()APIformatSyncSummary()to include renamed count in the notification messagesrc/plaud-sync.ts:
renamedcounter toPlaudSyncSummaryinterfaceExample behavior:
Before: Files named
plaud-2025-09-24-meeting-notes.mdAfter changing pattern to
{title}: Files renamed tomeeting-notes.mdSync message: "Plaud sync complete. Created 0, updated 5, renamed 3, skipped 2, failed 0."
The build completed successfully with no errors!