feat: implement option to exclude notes without transcription#5
Open
edabe wants to merge 3 commits into
Open
Conversation
Owner
|
Thanks for the clear implementation and PR summary. The feature shape looks good; I think this just needs a small readiness pass before merge:
After those are addressed and |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary: Add option to exclude notes without transcription
Overview
Adds a new user setting to skip syncing Plaud recordings that haven't been transcribed yet, preventing empty notes from cluttering the vault.
Changes
New Feature:
Files Modified
src/plaud-normalizer.ts
hasTranscript()helper functionsrc/settings-schema.ts
excludeWithoutTranscript: booleanto settings interfacenormalizeSettings()to handle new fieldfalsesrc/settings.ts
src/plaud-sync.ts
excludeWithoutTranscripttoPlaudSyncSettingsinterfacesrc/main.ts
Testing
false(current behavior)