Skip to content

chore: fix security vulnerabilities via npm audit - #2

Open
edabe wants to merge 1 commit into
leonardsellem:mainfrom
edabe:fix/security-vulnerabilities
Open

chore: fix security vulnerabilities via npm audit#2
edabe wants to merge 1 commit into
leonardsellem:mainfrom
edabe:fix/security-vulnerabilities

Conversation

@edabe

@edabe edabe commented May 5, 2026

Copy link
Copy Markdown

Thank you for putting this plugin together, much appreciated.

I'm giving it a try today and encountered vulnerabilities, so I'm submitting a PR to update package-lock.json to remediate them.

% npm ci                  

added 321 packages, and audited 322 packages in 2s

137 packages are looking for funding
  run `npm fund` for details

6 vulnerabilities (3 moderate, 3 high)

To address all issues, run:
  npm audit fix

Run `npm audit` for details.

@leonardsellem

Copy link
Copy Markdown
Owner

Thanks for taking the time to send this security cleanup.

I pulled the branch locally and the package install/build path looks healthy, but the audit remediation is not quite complete yet. The lockfile still resolves fast-uri to 3.1.0 at package-lock.json:2610, and npm audit --json still reports one high severity vulnerability for fast-uri:

  • GHSA-q3j6-qgpj-74h6
  • GHSA-v39h-62p7-jpjc

Could you please regenerate/update package-lock.json so that fast-uri resolves to 3.1.2 or newer through the eslint-plugin-obsidianmd / ajv dependency path, then rerun the audit?

I verified these commands on the PR branch:

npm ci --ignore-scripts   # passes, but still reports 1 high vulnerability
npm test                  # passes, 55/55
npm run build             # passes
npm audit --json          # fails: 1 high vulnerability in fast-uri

Once npm audit comes back clean, this should be in good shape from my side.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants