Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add config option for changing update interval. #302

Merged

Conversation

DurgNomis-drol
Copy link
Collaborator

@DurgNomis-drol DurgNomis-drol commented Aug 10, 2021

As discussed in #202 and comment

Adds ability for the user to change the update interval. This will make it possible for users who suffer for timeout problems to change their update interval as it seems this can help with it.

Also this now sets the default update interval to 180 seconds instead of 10 as pointed out in comment. Users should at their own risk tune it what they need.

This does not close. #202 but gives users more options to try to mitigate it.

@DurgNomis-drol DurgNomis-drol self-assigned this Aug 10, 2021
@github-actions github-actions bot added the translation Translations label Aug 10, 2021
@DurgNomis-drol DurgNomis-drol added feature New feature or request minor Minor changes. Used for release bump labels Aug 10, 2021
Copy link
Owner

@leikoilja leikoilja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for fixing it!

Were you able to validate it's working locally? :)
It would be so so nice to add a few lines to "README" about integration limitations explaining that the fetch rate is 3min and the user can tune it at their own risk. If we add it in the first part of README it can save a lot of time to some people. What do you think? (Edit: just saw your other comment that you were thinking of making a README as a separate PR. Sounds great 🚀 )

@DurgNomis-drol
Copy link
Collaborator Author

Thanks for approving🎉 I tested it locally and it works for me. 😊

@leikoilja
Copy link
Owner

Amazing then! Let's merge it in 🚀

Copy link
Collaborator

@KapJI KapJI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@KapJI KapJI merged commit 39b3d05 into leikoilja:master Aug 11, 2021
@leikoilja
Copy link
Owner

@DurgNomis-drol before we can release it in a next public release, can you please draft your thoughts regarding limitations in README? :)

@DurgNomis-drol
Copy link
Collaborator Author

Yes, I will try to get it done later today 😊

@DurgNomis-drol DurgNomis-drol deleted the add-update-interval-config-option branch August 11, 2021 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request minor Minor changes. Used for release bump translation Translations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants