Skip to content

Commit

Permalink
Bump up glocaltokens
Browse files Browse the repository at this point in the history
  • Loading branch information
leikoilja committed Apr 2, 2021
1 parent 688559f commit 6c0ffad
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 6 deletions.
2 changes: 1 addition & 1 deletion custom_components/google_home/manifest.json
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
"domain": "google_home",
"issue_tracker": "https://github.com/leikoilja/ha-google-home/issues",
"name": "Google Home",
"requirements": ["glocaltokens==0.2.7"],
"requirements": ["glocaltokens==0.2.8"],
"version": "1.0.1",
"zeroconf": ["_googlecast._tcp.local."]
}
8 changes: 4 additions & 4 deletions poetry.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ readme = "README.md"
python = "^3.8"
zeroconf = "^0.28.8"
homeassistant = "^2021.3.4"
glocaltokens = "0.2.7"
glocaltokens = "0.2.8"

This comment has been minimized.

Copy link
@leikoilja

leikoilja Apr 2, 2021

Author Owner

This technically should be taken care by dependabot from now on, right @KapJI? πŸ€”

This comment has been minimized.

Copy link
@KapJI

KapJI Apr 2, 2021

Collaborator

We set fixed version, so dependabot probably will skip it. But anyway we should update it at the same time with manifest.json to keep them in sync. After quick search I haven't found how to update manifest.json with dependabot.

I think I can write custom check to make sure these versions are in sync... one day πŸ™‚

This comment has been minimized.

Copy link
@leikoilja

leikoilja Apr 2, 2021

Author Owner

haha that could be a fun project to do! Please bundle it with a dependabot v2 that will just sync github releases version with all specified custom path (in our case manifest and pyproject) πŸ˜„


[tool.poetry.dev-dependencies]
black = "^20.8b1"
Expand Down

3 comments on commit 6c0ffad

@KapJI
Copy link
Collaborator

@KapJI KapJI commented on 6c0ffad Apr 2, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@leikoilja can you please try to use PR unless necessary?

Changes like this can easily break master if you forget to update poetry.lock, it's better to run CI first πŸ™‚

@leikoilja
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hahaha I was waiting for the remark like that one day πŸ˜…
But you are right, pushing to master is not a good habit, I'll stick to PRs πŸ‘ πŸ’―

@KapJI
Copy link
Collaborator

@KapJI KapJI commented on 6c0ffad Apr 3, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! πŸ™‚

Please sign in to comment.