Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Match devices by unique ID #160

Merged
merged 2 commits into from
Sep 6, 2021
Merged

Match devices by unique ID #160

merged 2 commits into from
Sep 6, 2021

Conversation

KapJI
Copy link
Collaborator

@KapJI KapJI commented Sep 4, 2021

Finally use these new IDs.

Problem

I have a speaker stereo pair which shows in the app (and in home graph) as a single virtual device with model Google Cast Group.

But when the main speaker in this pair is not reachable (due of leikoilja/ha-google-home#202), it starts to appear as name of that speaker instead of name of the pair.

This leads to non consistent results from glocaltokens.

Solution

Local auth tokens are actually per physical device, so glocaltokens should ignore any virtual groups and return only list of actual devices.

This unique id is the same for speaker pair device in home graph and actual device, so in both cases it'll be matched to corresponding network device. Use the name of that network device for consistency.

@KapJI KapJI added the feature New feature or request label Sep 4, 2021
@KapJI KapJI requested a review from leikoilja September 4, 2021 15:42
Copy link
Owner

@leikoilja leikoilja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great improvements, thank you, Sir 💯

@KapJI KapJI merged commit bb7ee8d into leikoilja:master Sep 6, 2021
@KapJI KapJI deleted the match-ids3 branch September 6, 2021 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants